Add SLH-DSA Support by aidangarske · Pull Request #455 · wolfSSL/wolfProvider

aidangarske · 2026-07-30T18:04:16Z

Description

Add FIPS 205 SLH-DSA support for all 12 parameter sets.
Implement key management, signatures, encoders, and decoders.
Support pure and external message encodings.
Support deterministic and seeded test operations.
Serialize operations that share mutable wolfSSL key state.
Support signing builds and verify-only wolfSSL builds.
Add OpenSSL KAT, interoperability, version-matrix, and unit coverage.
Pass all 20 SLH-DSA unit tests and 497 OpenSSL KAT vectors.
fixes the docker confusion and merges to main docker
Adds more osp intgration tests for mldsa, mlkem, slh-dsa
Adds simple example for PQC
depends on Encrypt PKCS#8 keys when a cipher is set on the PrivateKeyInfo encoder #453 which needs merged first
depends on Add libacvp PQC test coverage osp#351
Docs Document the wolfProvider post-quantum build options and defines documentation#274
revert osp patch to point to osp master

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Frauschi

🐺 Skoll Code Review

Overall recommendation: REQUEST_CHANGES
Findings: 12 total — 5 posted, 7 skipped

Posted findings

[High] openssl_example.c rewrite hard-fails on the IDE/Android and IDE/XCODE flows — examples/openssl_example.c:47-75 (duplicated in examples/pqc_openssl_example.c:225-238)
[Medium] KAT vector accounting: the verify-only SLH-DSA KAT can pass with zero vectors, the exact 3099 count is pinned against a floating OpenSSL tag, and the old 2602 comment was left behind — .github/workflows/wolfssl-versions-pqc.yml:204-214
[Medium] WOLFSSL_SLHDSA_CONFIG is missing from the dependency cache key, undocumented in --help, and contradicted by INTEGRATION_GUIDE — scripts/utils-wolfssl.sh:64-70
[Medium] Example build gating and portability: executableDir may trip -Wmaybe-uninitialized, and BUILD_PQC_EXAMPLE is true for verify-only SLH-DSA builds where the example always fails — examples/openssl_example.c:62-75; examples/pqc_openssl_example.c:225-238
[Low] wp_mlkem_kem.c doc comment no longer matches the code it documents — src/wp_mlkem_kem.c:186

Skipped findings

[High] libacvp PQC job likely cannot build runtest, so the whole workflow may no-op
[Medium] SLH-DSA test coverage gaps: four guard paths and the deterministic-keygen seed length validation are unexercised
[Low] CI workflow hygiene: example steps run before the dependency push, nginx-pqc adds per-workflow apt installs, and test.sh defaults WOLFPROV_ROOT to a path nothing produces
[Low] wp_slhdsa_key_types uses opaque index arithmetic into a flat parameter array
[Low] test_slhdsa.c hygiene: randomised input described as deterministic, a verify context initialised with sign-only params, mixed XMEM*/libc string calls, and redundant double cleanup
[Low] SLH-DSA locking contract is looser than the mutex implies: the key mutex is held across the full multi-second sign and across thread-local CheckKey work, wp_slhdsa_get_key() hands out a raw pointer to guarded state, and construction-time hasPub/hasPriv writes are unlocked
[Info] settings.h pulls a wolfSSL algorithm header into every translation unit

Review generated by Skoll via Claude/Codex

Frauschi

🐺 Skoll Code Review

Overall recommendation: APPROVE
Findings: 16 total — 7 posted, 9 skipped

Posted findings

[Medium] SLH-DSA verify-only CI row is indistinguishable from the plain slhdsa row and cannot detect a lost WOLFSSL_SLHDSA_CONFIG — .github/workflows/wolfssl-versions-pqc.yml:183-191
[Medium] wc_SlhDsaKey_CheckKey runs twice on every SLH-DSA keypair import — src/wp_slhdsa_kmgmt.c:854,895
[Low] wp_slhdsa_validate holds keyMutex across a full key copy and wc_SlhDsaKey_CheckKey — src/wp_slhdsa_kmgmt.c:745-795
[Low] nginx-pqc installs packages that are already baked into the test-deps image, against that image's stated policy — .github/workflows/nginx-pqc.yml:132-136
[Low] Missing cast on OPENSSL_malloc return — src/wp_slhdsa_kmgmt.c:766
[Low] if (dupPub) is not guarded by ok while the adjacent if (ok && dupPriv) is — src/wp_slhdsa_kmgmt.c:455
[Low] word32 sigSz; declared uninitialized in wp_slhdsa_sign — src/wp_slhdsa_sig.c:344

Skipped findings

[Low] run_vector_family silently mutates its caller's local counters via bash dynamic scoping
[Low] 7 of 12 SLH-DSA AlgorithmIdentifier OID arcs are never exercised by any test
[Low] extra_key gains a stray trailing dash on 7 of 8 matrix rows
[Low] wp_slhdsa_validate nests refMutex inside keyMutex and runs the full CheckKey inside the shared key's critical section
[Low] wp_slhdsa_sign and wp_slhdsa_verify hold the per-key mutex across the entire multi-second wolfSSL SLH-DSA operation
[Info] Do not 'fix' SLH-DSA's export_object / verify_message_final to match ML-DSA and ECX -- SLH-DSA is the correct one
[Info] Examples gate on the configure macro WOLFPROV_HAVE_* rather than the resolved WP_HAVE_*
[Info] encData cleansed with post-encryption length instead of allocation size
[Info] Three sites write hasPub/hasPriv without keyMutex, contradicting the invariant documented at wp_slhdsa_kmgmt.c:271

Review generated by Skoll via Claude/Codex

Copilot

Pull request overview

Copilot reviewed 32 out of 32 changed files in this pull request and generated no new comments.

Suppressed comments (1)

docs/INTEGRATION_GUIDE.md:171

The updated PQC requirements still say that any OpenSSL 3.x is supported on the next line, but settings.h gates ML-KEM, ML-DSA, and SLH-DSA on OpenSSL 3.6+. Following this guide with OpenSSL 3.0–3.5 therefore ends in a compile-time error. Update the OpenSSL requirement to 3.6+.

- **wolfSSL**: v5.9.2-stable or later. v5.9.1-stable defines `HAVE_DILITHIUM` and exposes `wc_dilithium_sign_ctx_msg` (the older name for the FIPS 204 pure-mode signer) but does not yet ship the canonical `WOLFSSL_HAVE_MLDSA` macro, `<wolfssl/wolfcrypt/wc_mldsa.h>` header, or `wc_MlDsaKey_SignCtx` alias that wolfProvider gates on.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #455

Scan targets checked: wolfprovider-bugs, wolfprovider-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

padelsbach · 2026-08-13T18:13:25Z

+
+#include "unit.h"
+
+#include <openssl/core_names.h>


Can you add some A/B comparison scenarios to this file between WP and OSSL? Iiuc, the outputs should be byte identical

Added WP/OpenSSL A/B checks for identical seeded keys and deterministic signatures.

padelsbach · 2026-08-13T18:24:51Z


 #include <wolfssl/wolfcrypt/wc_mlkem.h>
 #include <wolfssl/wolfcrypt/wc_mldsa.h>
+#if defined(WP_HAVE_SLHDSA) && defined(WP_HAVE_SLHDSA_PRIVATE) && \


For interop testing, can you add PEM and DER file interop between WP and OSSL?

Added DER and PEM key-file interop in both directions.

padelsbach · 2026-08-13T18:26:32Z


 #include <wolfprovider/settings.h>

 #if defined(WP_HAVE_MLKEM) && defined(WP_HAVE_MLDSA)


The WP_HAVE_SLHDSA check is within the WP_HAVE_MLKEM check. Shouldn't these be orthogonal?

Made the SLH-DSA tests independent of the ML-KEM build guards.

padelsbach · 2026-08-13T18:42:10Z

+
+/* Parameter set tables. Security category follows FIPS 205 Table 2. */
+#ifdef WP_HAVE_SLH_DSA_SHAKE_128S
+static const wp_SlhDsaData slhdsaShake128sData = {


AI tells me only 5 of the 12 of this table are covered by tests

Added keygen and metadata coverage for all 12 parameter sets.

aidangarske · 2026-08-14T00:16:37Z

Jenkins retest this please

Copilot AI review requested due to automatic review settings July 30, 2026 18:04

Copilot AI reviewed Jul 30, 2026

aidangarske force-pushed the add-slhdsa branch 2 times, most recently from 0487400 to 02cbe8b Compare July 30, 2026 18:27

aidangarske added the ci:nginx-pqc PR OSP toggle: run nginx-pqc label Jul 30, 2026

aidangarske force-pushed the add-slhdsa branch from 02cbe8b to 7f53091 Compare July 30, 2026 22:41

aidangarske added ci:libacvp-pqc PR OSP toggle: run libacvp-pqc and removed ci:nginx-pqc PR OSP toggle: run nginx-pqc ci:libacvp-pqc PR OSP toggle: run libacvp-pqc labels Jul 30, 2026

aidangarske force-pushed the add-slhdsa branch from e77b5f9 to 7fa1616 Compare July 30, 2026 23:11

aidangarske added ci:libacvp-pqc PR OSP toggle: run libacvp-pqc and removed ci:libacvp-pqc PR OSP toggle: run libacvp-pqc labels Jul 30, 2026

aidangarske marked this pull request as ready for review July 30, 2026 23:26

aidangarske assigned padelsbach Jul 30, 2026

aidangarske requested review from ColtonWilley, Frauschi and padelsbach July 30, 2026 23:29

aidangarske assigned aidangarske and unassigned padelsbach Jul 30, 2026

aidangarske force-pushed the add-slhdsa branch 2 times, most recently from 8bf2ba2 to ba88c76 Compare July 31, 2026 01:05

aidangarske added ci:libacvp-pqc PR OSP toggle: run libacvp-pqc and removed ci:libacvp-pqc PR OSP toggle: run libacvp-pqc labels Jul 31, 2026

This comment was marked as resolved.

Sign in to view

aidangarske force-pushed the add-slhdsa branch from ba88c76 to ea5bdec Compare July 31, 2026 18:01

aidangarske added ci:libacvp-pqc PR OSP toggle: run libacvp-pqc and removed ci:libacvp-pqc PR OSP toggle: run libacvp-pqc labels Jul 31, 2026

aidangarske requested a review from Frauschi July 31, 2026 19:38

aidangarske removed the ci:libacvp-pqc PR OSP toggle: run libacvp-pqc label Aug 1, 2026

aidangarske added 2 commits August 5, 2026 13:38

Complete SLH-DSA review hardening

2bac2ea

Use upstream OSP for libacvp tests

7229818

aidangarske force-pushed the add-slhdsa branch from e440389 to 9010404 Compare August 5, 2026 20:58

aidangarske added ci:libacvp-pqc PR OSP toggle: run libacvp-pqc and removed ci:libacvp-pqc PR OSP toggle: run libacvp-pqc labels Aug 5, 2026

aidangarske requested a review from Frauschi August 5, 2026 21:01

Frauschi requested changes Aug 6, 2026

View reviewed changes

Comment thread examples/openssl_example.c

Comment thread .github/workflows/wolfssl-versions-pqc.yml

Comment thread scripts/utils-wolfssl.sh

Comment thread src/wp_mlkem_kem.c Outdated

Address SLH-DSA review findings

c9b5867

aidangarske force-pushed the add-slhdsa branch from 9010404 to c9b5867 Compare August 6, 2026 20:33

aidangarske requested a review from Frauschi August 6, 2026 20:34

Frauschi reviewed Aug 7, 2026

View reviewed changes

Deduplicate SLH-DSA keypair import validation and address review nits

149892f

aidangarske requested review from wolfSSL-Fenrir-bot and a balanced review from Copilot August 7, 2026 19:34

Copilot started reviewing on behalf of aidangarske August 7, 2026 19:36 View session

Copilot AI reviewed Aug 7, 2026

View reviewed changes

wolfSSL-Fenrir-bot reviewed Aug 7, 2026

View reviewed changes

Comment thread test/test_slhdsa.c

Comment thread src/wp_slhdsa_sig.c

Cover SLH-DSA undersized-buffer and mid-stream domain-change rejects

8abe14e

aidangarske added ci:libacvp-pqc PR OSP toggle: run libacvp-pqc and removed ci:libacvp-pqc PR OSP toggle: run libacvp-pqc labels Aug 8, 2026

aidangarske requested a review from Frauschi August 8, 2026 17:05

padelsbach reviewed Aug 13, 2026

View reviewed changes

aidangarske added 2 commits August 13, 2026 15:39

Address SLH-DSA review feedback

5b57fe1

Fix SLH-DSA verify-only test build

401ae2f

aidangarske added ci:libacvp-pqc PR OSP toggle: run libacvp-pqc and removed ci:libacvp-pqc PR OSP toggle: run libacvp-pqc labels Aug 14, 2026


		#include <wolfprovider/settings.h>

		#if defined(WP_HAVE_MLKEM) && defined(WP_HAVE_MLDSA)

Uh oh!

Conversation

aidangarske commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

🐺 Skoll Code Review

Posted findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

🐺 Skoll Code Review

Posted findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #455

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aidangarske commented Aug 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aidangarske commented Jul 30, 2026 •

edited

Loading